Skip to content

Comments

[25.11] treewide: clean up 'meta = with' pattern#469667

Merged
wolfgangwalther merged 1 commit intoNixOS:release-25.11from
wolfgangwalther:backport-meta-with-lib-removal
Dec 10, 2025
Merged

[25.11] treewide: clean up 'meta = with' pattern#469667
wolfgangwalther merged 1 commit intoNixOS:release-25.11from
wolfgangwalther:backport-meta-with-lib-removal

Conversation

@wolfgangwalther
Copy link
Contributor

@wolfgangwalther wolfgangwalther commented Dec 10, 2025

Backport of #443046 - just ran the scripts again.

@booxter @wolfgangwalther
treewide: clean up 'meta = with' pattern
cca3b04 
This commit was created by a combination of scripts and tools:
- an ast-grep script to prefix things in meta with `lib.`,
- a modified nixf-diagnose / nixf combination to remove unused `with lib;`, and
- regular nixfmt.

Co-authored-by: Wolfgang Walther <walther@technowledgy.de>
@wolfgangwalther wolfgangwalther mentioned this pull request Dec 10, 2025
Merged
13 tasks
github-actions[bot]
github-actions bot previously requested changes Dec 10, 2025
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This report is automatically generated by the PR / Check / cherry-pick CI workflow.

Some of the commits in this PR require the author's and reviewer's attention.

Please follow the backporting guidelines and cherry-pick with the -x flag.
This requires changes to the unstable master and staging branches first, before backporting them.

Occasionally, commits are not cherry-picked at all, for example when updating minor versions of packages which have already advanced to the next major on unstable.
These commits can optionally be marked with a Not-cherry-picked-because: <reason> footer.

If you need to merge this PR despite the warnings, please dismiss this review shortly before merging.

Warning

Couldn't locate the cherry-picked commit's hash in the commit message of cca3b04.

Hint: The full diffs are also available in the runner logs with slightly better highlighting.

@wolfgangwalther wolfgangwalther dismissed github-actions[bot]’s stale review December 10, 2025 18:05

Not a cherry-picked, because it was created from scratch.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Dec 10, 2025
@wolfgangwalther wolfgangwalther added this pull request to the merge queue Dec 10, 2025
@wolfgangwalther wolfgangwalther mentioned this pull request Dec 10, 2025
Merged
@nixpkgs-ci nixpkgs-ci bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: emacs Text editor 6.topic: vim Advanced text editor 6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment 6.topic: hardware Drivers, Firmware and Kernels 6.topic: coq A formal proof management system 6.topic: pantheon The Pantheon desktop environment 6.topic: cinnamon Desktop environment 6.topic: docker tools Open-source software for deploying and running of containerized applications 6.topic: R R is a programming language for statistical computing and data visualization. 6.topic: vscode A free and versatile code editor that supports almost every major programming language. 6.topic: jupyter Interactive computing tooling: kernels, notebook, jupyterlab 6.topic: COSMIC COSMIC is a software platform for designing beautiful user experiences 4.workflow: backport This targets a stable branch labels Dec 10, 2025
Merged via the queue into NixOS:release-25.11 with commit 93ad9a3 Dec 10, 2025
44 checks passed
@wolfgangwalther wolfgangwalther deleted the backport-meta-with-lib-removal branch December 10, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees

No one assigned

Labels

4.workflow: backport This targets a stable branch 6.topic: cinnamon Desktop environment 6.topic: coq A formal proof management system 6.topic: COSMIC COSMIC is a software platform for designing beautiful user experiences 6.topic: docker tools Open-source software for deploying and running of containerized applications 6.topic: emacs Text editor 6.topic: hardware Drivers, Firmware and Kernels 6.topic: jupyter Interactive computing tooling: kernels, notebook, jupyterlab 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment 6.topic: pantheon The Pantheon desktop environment 6.topic: R R is a programming language for statistical computing and data visualization. 6.topic: vim Advanced text editor 6.topic: vscode A free and versatile code editor that supports almost every major programming language. 8.has: module (update) This PR changes an existing module in `nixos/` 9.needs: reviewer This PR currently has no reviewers requested and needs attention. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wolfgangwalther @booxter